Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 13_0_X for Py8PtExpGun #43436

Merged

Conversation

bennettgberg
Copy link

PR description:

Backport to 13_0_X for: #43354

Adds a Pythia8 Pt Gun with an exponentially falling pT distribution instead of the uniform one.
This backport is needed for Summer23 Central MC production, as requested by PdmV according to the comments on this JIRA ticket: https://its.cern.ch/jira/browse/CMSBPHMC-52

PR validation:

Thoroughly tested in CMSSW_12_4_17 and CMSSW_13_0_14 by generating test events. Also ran code-checks, code-format, and runTheMatrix.py for the master PR. This is just adding a new plugin, so it will not affect any previously existing CMSSW code.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bennettgberg for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/Pythia8Interface (generators)

@mkirsano, @cmsbuild, @bbilin, @alberto-sanchez, @GurpreetSinghChahal, @menglu21, @SiewYan can you please review it and eventually sign? Thanks.
@mkirsano, @missirol, @Martin-Grunewald, @alberto-sanchez, @fabiocos this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bbilin
Copy link
Contributor

bbilin commented Nov 30, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5c99b/36212/summary.html
COMMIT: 77c8f7b
CMSSW: CMSSW_13_0_X_2023-11-26-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43436/36212/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 54 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283595
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@bbilin
Copy link
Contributor

bbilin commented Dec 2, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4559daa into cms-sw:CMSSW_13_0_X Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants